From: Simon Wilkinson <sxw@your-file-system.com>
Date: Fri, 30 Mar 2012 18:12:37 +0000 (+0100)
Subject: Unix CM: Purge needless brackets
X-Git-Tag: upstream/1.6.8^2~78
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=29a6e95cddff3dab9477937bcd0c64ef2ff00809;p=packages%2Fo%2Fopenafs.git

Unix CM: Purge needless brackets

Doing if ((a==b)) is unecessary. It's also potentially dangerous, as
that's the syntax required to do assignment within an if statement.
clang now issues warnings (errors in -Werror mode) when it encounters
these.

Remove pointless braces from the Unix CM to make clang happy.

Reviewed-on: http://gerrit.openafs.org/7074
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 345656ec140f0156f2076629bdfc84940c02160b)

Change-Id: I6a47d30fd6ef0ad0c6903c79a0bfe579db527847
Reviewed-on: http://gerrit.openafs.org/10743
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
---

diff --git a/src/afs/afs_osidnlc.c b/src/afs/afs_osidnlc.c
index 6deb89c29..9df2b0dea 100644
--- a/src/afs/afs_osidnlc.c
+++ b/src/afs/afs_osidnlc.c
@@ -456,7 +456,7 @@ osi_dnlc_purgevp(struct vcache *avc)
     writelocked = (0 == NBObtainWriteLock(&afs_xdnlc, 3));
 
     for (i = 0; i < NCSIZE; i++) {
-	if ((nameCache[i].vp == avc)) {
+	if (nameCache[i].vp == avc) {
 	    nameCache[i].dirp = nameCache[i].vp = NULL;
 	    /* can't simply break; because of hard links -- might be two */
 	    /* different entries with same vnode */