From: Simon Wilkinson <sxw@your-file-system.com>
Date: Sun, 24 Feb 2013 10:43:52 +0000 (+0000)
Subject: budb: Fail if afsconf_GetExtendedCellInfo does
X-Git-Tag: upstream/1.6.3^2~90
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=2b14a3b290b7f459edb426fa70b18c14e369596e;p=packages%2Fo%2Fopenafs.git

budb: Fail if afsconf_GetExtendedCellInfo does

Rather than silently ignoring the failure of
afsconf_GetExtendedCellInfo, and then using garbage cell
configuration, just fail to start if afsconf can't parse the
config directory.

Reviewed-on: http://gerrit.openafs.org/9247
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit 3fbdc609dc025cfcaac6949485d6fb072bf34764)

Change-Id: I40f0aefda1bc44ce92a7733ec644002229c32079
Reviewed-on: http://gerrit.openafs.org/9536
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
---

diff --git a/src/budb/server.c b/src/budb/server.c
index e5cb4600d..9fd3bc2cb 100644
--- a/src/budb/server.c
+++ b/src/budb/server.c
@@ -494,6 +494,11 @@ main(int argc, char **argv)
 
 	code = afsconf_GetExtendedCellInfo (BU_conf, lcell, 0, &cellinfo,
 					    clones);
+	if (code) {
+	    LogError(0, "Can't read cell information\n");
+	    ERROR(code);
+	}
+
 	code =
 	    convert_cell_to_ubik(&cellinfo, &globalConfPtr->myHost,
 				 globalConfPtr->serverList);