From: Jeffrey Altman <jaltman@mit.edu>
Date: Fri, 2 Apr 2004 17:41:27 +0000 (+0000)
Subject: unitialized-return-variable-20040402
X-Git-Tag: openafs-devel-1_3_63~18
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=2d0b67fed04275407daa5f9f1130def159bdc063;p=packages%2Fo%2Fopenafs.git

unitialized-return-variable-20040402


krb5_des_decrypt() does not initialize the return value to 1, failure,
therefore it returns random success (0) values when ticket types of
DES-CBC-MD5 or DES-CBC-MD4 are used because we do not have checksum
functions for those types.
---

diff --git a/src/rxkad/ticket5.c b/src/rxkad/ticket5.c
index 8abf468e9..9c22d208a 100644
--- a/src/rxkad/ticket5.c
+++ b/src/rxkad/ticket5.c
@@ -413,7 +413,7 @@ krb5_des_decrypt(struct ktc_encryptionKey *key, int etype, void *in,
     des_key_schedule s;
     char cksum[24];
     size_t cksumsz;
-    int ret;
+    int ret = 1;	/* failure */
 
     cksum_func = NULL;