From: Simon Wilkinson Date: Tue, 18 Aug 2009 21:31:38 +0000 (+0100) Subject: Make MacOS installer pane permit dashes X-Git-Tag: openafs-stable-1_4_12pre1~47 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=326d7100c7c26674de47cab8a8b10631dabddd35;p=packages%2Fo%2Fopenafs.git Make MacOS installer pane permit dashes The MacOS installer only permits characters in [0-9A-Za-z] in cellnames. However, OpenAFS itself will also allow dashes, and they're in use by some sites. This trivially amends the installer pane to permit dashes. FIXES 125211 Reviewed-on: http://gerrit.openafs.org/323 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear (cherry picked from commit 57e218ab61e824133f252e4a0da74552beb14b05) Change-Id: I0b37eb4a3f0aeb530d91341896c797dbf2aaeb2d Reviewed-on: http://gerrit.openafs.org/953 --- diff --git a/src/platform/DARWIN/afscell/afscellPane.m b/src/platform/DARWIN/afscell/afscellPane.m index 1b1ec29eb..098e62dca 100644 --- a/src/platform/DARWIN/afscell/afscellPane.m +++ b/src/platform/DARWIN/afscell/afscellPane.m @@ -20,7 +20,9 @@ NSString *fileWriteCellAlias=@"/private/tmp/org.OpenAFS.Install.CellAlias"; /* check line of CellAlias provided for Cell name, if matches, returns alias in third parameter */ - (BOOL)_cellInCellAliasLine:(NSString *)line cellName:(NSString *)cell intoAlias:(NSString **)alias { - NSCharacterSet *alphaNum = [NSCharacterSet alphanumericCharacterSet]; + NSMutableCharacterSet *alphaNum = [[NSCharacterSet alphanumericCharacterSet] mutableCopy]; + [alphaNum addCharactersInString:@"-"]; + NSScanner *cellScanner = [NSScanner scannerWithString:line]; if (![cellScanner scanUpToString:cell intoString:nil]) { @@ -108,7 +110,8 @@ NSString *fileWriteCellAlias=@"/private/tmp/org.OpenAFS.Install.CellAlias"; } /* make sure it's in internet domain style, i.e. alphanum.alphanum */ - NSCharacterSet *alphaNum = [NSCharacterSet alphanumericCharacterSet]; + NSMutableCharacterSet *alphaNum = [[NSCharacterSet alphanumericCharacterSet] mutableCopy]; + [alphaNum addCharactersInString:@"-"]; NSScanner *cellScanner = [NSScanner scannerWithString:cellString]; /* first 'word' */ @@ -141,7 +144,8 @@ NSString *fileWriteCellAlias=@"/private/tmp/org.OpenAFS.Install.CellAlias"; } /* make sure it's alpha-numeric */ - NSCharacterSet *alphaNum = [NSCharacterSet alphanumericCharacterSet]; + NSMutableCharacterSet *alphaNum = [[NSCharacterSet alphanumericCharacterSet] mutableCopy]; + [alphaNum addCharactersInString:@"-"]; NSScanner *aliasScanner = [NSScanner scannerWithString:aliasString]; if (![aliasScanner scanCharactersFromSet:alphaNum intoString:nil])