From: Simon Wilkinson <sxw@your-file-system.com>
Date: Sun, 24 Feb 2013 13:02:19 +0000 (+0000)
Subject: budb: Don't double initialise iterator
X-Git-Tag: upstream/1.8.0_pre1^2~1427
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=356bdc8ca77a42e359fed64bef7d77d70e14e4a4;p=packages%2Fo%2Fopenafs.git

budb: Don't double initialise iterator

The blockaddr iterator is initialised as part of the for loop.
Don't also initialise it immediately before.

Caught by clang-analyzer

Change-Id: I97e7ced15fe204b3b2d797abbdce8b3f9a2b0c8d
Reviewed-on: http://gerrit.openafs.org/9253
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/src/budb/ol_verify.c b/src/budb/ol_verify.c
index 2c8871776..aeb3cdf81 100644
--- a/src/budb/ol_verify.c
+++ b/src/budb/ol_verify.c
@@ -1188,7 +1188,6 @@ verifyTextChain(struct ubik_trans *ut, struct textBlock *tbPtr)
 
     for (new = 0; new < 2; new++) {
 	size = 0;
-	blockAddr = ntohl(tbPtr->textAddr);
 
 	for (blockAddr =
 	     (new ? ntohl(tbPtr->newTextAddr) : ntohl(tbPtr->textAddr));