From: Simon Wilkinson <sxw@inf.ed.ac.uk>
Date: Tue, 15 Jun 2010 17:09:53 +0000 (+0100)
Subject: libcmd: Don't increment array then discard result
X-Git-Tag: upstream/1.8.0_pre1^2~3492
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=364d1bec7458b874922f5d1e9be49f7a1f813136;p=packages%2Fo%2Fopenafs.git

libcmd: Don't increment array then discard result

We don't need to increment argv here, as we're about to return
to the caller.

Change-Id: I442fe741e4bda91e12375a6fe72657dc215c4e78
Reviewed-on: http://gerrit.openafs.org/5078
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
---

diff --git a/src/cmd/cmd.c b/src/cmd/cmd.c
index 1ead1ca24..90fa470d4 100644
--- a/src/cmd/cmd.c
+++ b/src/cmd/cmd.c
@@ -1159,7 +1159,7 @@ CopyBackArgs(struct cmd_token *alist, char **argv,
 	argv++;
 	count++;
     }
-    *(argv++) = 0;		/* use last slot for terminating null */
+    *argv = NULL;		/* use last slot for terminating null */
     /* don't count terminating null */
     *an = count;
     return 0;