From: Chaskiel M Grundman <cg2v@andrew.cmu.edu>
Date: Fri, 21 Mar 2003 18:28:31 +0000 (+0000)
Subject: linux-hold-tasklist-lock-in-get-page-offset-20030321
X-Git-Tag: openafs-devel-1_3_50~300
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=38cec12f2c45d4d2f544acedeeffafec70a89582;p=packages%2Fo%2Fopenafs.git

linux-hold-tasklist-lock-in-get-page-offset-20030321


tasklist_lock must be held to traverse list
---

diff --git a/src/afs/LINUX/osi_module.c b/src/afs/LINUX/osi_module.c
index 6629b344c..4d5227d7a 100644
--- a/src/afs/LINUX/osi_module.c
+++ b/src/afs/LINUX/osi_module.c
@@ -25,9 +25,9 @@ RCSID("$Header$");
 #include <linux/slab.h>
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)
 #include <linux/init.h>
+#include <linux/sched.h>
 #endif
 #ifndef EXPORTED_SYS_CALL_TABLE
-#include <linux/sched.h>
 #include <linux/syscall.h>
 #endif
 
@@ -439,15 +439,27 @@ static long get_page_offset(void)
 #else
     struct task_struct *p, *q;
 
+    /* search backward thru the circular list */
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)
+    read_lock(&tasklist_lock);
+#endif
     /* search backward thru the circular list */
 #ifdef DEFINED_PREV_TASK
-    for(q = current; p = q; q = prev_task(p))
+    for(q = current; p = q; q = prev_task(p)) {
 #else
-    for(p = current; p; p = p->prev_task)
+    for(p = current; p; p = p->prev_task) {
 #endif
-	if (p->pid == 1)
-	    return p->addr_limit.seg;
-
-    return 0;
+	    if (p->pid == 1) {
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)
+		    read_unlock(&tasklist_lock);
+#endif
+		    return p->addr_limit.seg;
+	    }
+    }
+  
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)
+    read_unlock(&tasklist_lock);
+#endif
+  return 0;
 #endif
 }