From: Marc Dionne Date: Sun, 3 Oct 2010 01:02:23 +0000 (-0400) Subject: Linux: correct use of atomic_add and atomic_sub functions X-Git-Tag: upstream/1.8.0_pre1^2~4726 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=3940e686a880410b9001786734d158411782a965;p=packages%2Fo%2Fopenafs.git Linux: correct use of atomic_add and atomic_sub functions The rx_atomic_add and rx_atomic_sub functions have arguments reversed compared to the linux atomic_add and atomic_sub. Adjust the macros to flip the arguments when calling them Change-Id: I6d58c8f0ac8ccf09e62c9d3921b9f3ae50ca94c9 Reviewed-on: http://gerrit.openafs.org/2889 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- diff --git a/src/rx/rx_atomic.h b/src/rx/rx_atomic.h index 805c285b7..1fdd66d59 100644 --- a/src/rx/rx_atomic.h +++ b/src/rx/rx_atomic.h @@ -120,9 +120,9 @@ typedef atomic_t rx_atomic_t; #define rx_atomic_read(X) atomic_read(X) #define rx_atomic_inc(X) atomic_inc(X) #define rx_atomic_inc_and_read(X) atomic_inc_return(X) -#define rx_atomic_add(X, V) atomic_add(X, V) +#define rx_atomic_add(X, V) atomic_add(V, X) #define rx_atomic_dec(X) atomic_dec(X) -#define rx_atomic_sub(X, V) atomic_sub(X, V) +#define rx_atomic_sub(X, V) atomic_sub(V, X) #elif defined(AFS_SUN58_ENV) typedef struct {