From: Garrett Wollman Date: Wed, 25 Jul 2012 04:06:05 +0000 (-0400) Subject: kauth: ka_CellToRealm's "realm" parameter cannot be null X-Git-Tag: upstream/1.8.0_pre1^2~2150 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=3f691e663cc55ffb89386e53535030c659cb2fc2;p=packages%2Fo%2Fopenafs.git kauth: ka_CellToRealm's "realm" parameter cannot be null Annotate ka_CellToRealm with AFS_NONNULL to indicate that its "realm" parameter cannot be null; it does not make sense to call this routine without this parameter. (The static analyzer inlines the call to ka_ExpandCell and concludes that "realm" might be null; the annotation will prevent that and avoid a false positive.) Change-Id: Id7fac19cf4eb4bdb1decde81d951b8bcd96fce71 Reviewed-on: http://gerrit.openafs.org/7865 Reviewed-by: Derrick Brashear Tested-by: BuildBot --- diff --git a/src/kauth/kautils.p.h b/src/kauth/kautils.p.h index 3b7eaa494..b15c22601 100644 --- a/src/kauth/kautils.p.h +++ b/src/kauth/kautils.p.h @@ -124,7 +124,7 @@ extern char *ka_LocalCell(void extern int ka_ExpandCell(char *cell, char *fullCell, int *alocal); -extern int ka_CellToRealm(char *cell, char *realm, int *local); +extern int ka_CellToRealm(char *cell, char *realm, int *local) AFS_NONNULL((2)); extern void ka_PrintUserID(char *prefix, char *name, char *instance, char *postfix);