From: Simon Wilkinson <sxw@your-file-system.com>
Date: Sun, 24 Feb 2013 10:43:52 +0000 (+0000)
Subject: budb: Fail if afsconf_GetExtendedCellInfo does
X-Git-Tag: upstream/1.8.0_pre1^2~1433
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=3fbdc609dc025cfcaac6949485d6fb072bf34764;p=packages%2Fo%2Fopenafs.git

budb: Fail if afsconf_GetExtendedCellInfo does

Rather than silently ignoring the failure of
afsconf_GetExtendedCellInfo, and then using garbage cell
configuration, just fail to start if afsconf can't parse the
config directory.

Change-Id: Ib3d26bc67844de10f7eb8c2ef555c5e607e4bf61
Reviewed-on: http://gerrit.openafs.org/9247
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/src/budb/server.c b/src/budb/server.c
index dd8f24f1b..ee4536c40 100644
--- a/src/budb/server.c
+++ b/src/budb/server.c
@@ -482,6 +482,11 @@ main(int argc, char **argv)
 
 	code = afsconf_GetExtendedCellInfo (BU_conf, lcell, 0, &cellinfo,
 					    clones);
+	if (code) {
+	    LogError(0, "Can't read cell information\n");
+	    ERROR(code);
+	}
+
 	code =
 	    convert_cell_to_ubik(&cellinfo, &globalConfPtr->myHost,
 				 globalConfPtr->serverList);