From: Garrett Wollman <wollman@csail.mit.edu>
Date: Sun, 7 Aug 2011 03:15:14 +0000 (-0400)
Subject: vos: don't free stack garbage on error
X-Git-Tag: upstream/1.6.0^2~41
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=3fd135d48b76b2e54329b75e53a67cac1abb29d4;p=packages%2Fo%2Fopenafs.git

vos: don't free stack garbage on error

If wantExtendedInfo is true, then pntr is used uninitialized.
In the other case, UV_ListVolumes will have set it to NULL
before doing anything (even if it returns an error), so this
free() is dead anyway.

Found-by: clang static analyzer
Reviewed-on: http://gerrit.openafs.org/5164
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 619b420903c99e48618db0d2f12085111573f279)

Change-Id: Icd76d3ac160ccb04b05445552a9e6d04f053efbb
Reviewed-on: http://gerrit.openafs.org/5227
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
---

diff --git a/src/volser/vos.c b/src/volser/vos.c
index 389e84689..a48494b24 100644
--- a/src/volser/vos.c
+++ b/src/volser/vos.c
@@ -3736,8 +3736,6 @@ ListVolumes(struct cmd_syndesc *as, void *arock)
 				   &pntr, &count);
 	    if (code) {
 		PrintDiagnostics("listvol", code);
-		if (pntr)
-		    free(pntr);
 		exit(1);
 	    }
 	    if (wantExtendedInfo) {