From: Jeffrey Altman Date: Mon, 9 Aug 2004 21:51:56 +0000 (+0000) Subject: null-pointer-20040809 X-Git-Tag: BP-disconnected~294 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=3fd571cb1014f61101e0b82fc9944f9d5285cea1;p=packages%2Fo%2Fopenafs.git null-pointer-20040809 protect against a null pointer reference in smb_ReceiveV3Trans when its the first packet and the totalData and totalParms are 0 --- diff --git a/src/WINNT/afsd/smb3.c b/src/WINNT/afsd/smb3.c index e9468b097..2f8b3241d 100644 --- a/src/WINNT/afsd/smb3.c +++ b/src/WINNT/afsd/smb3.c @@ -1305,7 +1305,9 @@ long smb_ReceiveV3Trans(smb_vc_t *vcp, smb_packet_t *inp, smb_packet_t *outp) asp->curParms += parmCount; /* finally, if we're done, remove the packet from the queue and dispatch it */ - if (asp->totalData <= asp->curData && asp->totalParms <= asp->curParms) { + if (asp->curData > 0 && asp->curParms > 0 && + asp->totalData <= asp->curData && + asp->totalParms <= asp->curParms) { /* we've received it all */ lock_ObtainWrite(&smb_globalLock); osi_QRemove((osi_queue_t **) &smb_tran2AssemblyQueuep, &asp->q);