From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Wed, 3 Sep 2008 21:37:00 +0000 (+0000)
Subject: windows-smb-lock-order-20080903
X-Git-Tag: openafs-devel-1_5_61~840
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=441cc643e027ab98ed14ab486ec077bbbd0c0d4f;p=packages%2Fo%2Fopenafs.git

windows-smb-lock-order-20080903

LICENSE MIT

another lock order violation to fix
---

diff --git a/src/WINNT/afsd/smb.c b/src/WINNT/afsd/smb.c
index a5d5da63e..ae083f9f6 100644
--- a/src/WINNT/afsd/smb.c
+++ b/src/WINNT/afsd/smb.c
@@ -9860,6 +9860,7 @@ void smb_Shutdown(void)
             if (fidp->scp != NULL) {
                 cm_scache_t * scp;
 
+                lock_ReleaseWrite(&smb_rctLock);
                 lock_ObtainMutex(&fidp->mx);
                 if (fidp->scp != NULL) {
                     scp = fidp->scp;
@@ -9871,6 +9872,7 @@ void smb_Shutdown(void)
                     cm_ReleaseSCache(scp);
                 }
                 lock_ReleaseMutex(&fidp->mx);
+                lock_ObtainWrite(&smb_rctLock);
             }
         }