From: Jim Rees <rees@umich.edu>
Date: Mon, 10 Nov 2003 22:25:28 +0000 (+0000)
Subject: rmtsys-uninit-20031110
X-Git-Tag: openafs-devel-1_3_50~34
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=456f1dfdc6cb04ba93e58b5af58e86305bb173cf;p=packages%2Fo%2Fopenafs.git

rmtsys-uninit-20031110


fix uninitialized variable found by jbuehler@hekimian.com
consolidate duplicate cases so this won't happen again
---

diff --git a/src/sys/rmtsysnet.c b/src/sys/rmtsysnet.c
index 45209354b..907f93ff8 100644
--- a/src/sys/rmtsysnet.c
+++ b/src/sys/rmtsysnet.c
@@ -282,48 +282,14 @@ inparam_conversion(afs_int32 cmd, char *buffer, afs_int32 ntoh_conv)
 	RFetchVolumeStatus_conversion(buffer, ntoh_conv);
 	break;
     case VIOCGETTOK & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOCCKSERV & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOCACCESS & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOCSETCACHESIZE & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOCGETCELL & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOC_AFS_MARINER_HOST & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOC_VENUSLOG & 0xffff:
+    case VIOC_AFS_SYSNAME & 0xffff:
+    case VIOC_EXPORTAFS & 0xffff:
 	lptr = (afs_int32 *) buffer;
 	if (ntoh_conv)
 	    *lptr = ntohl(*lptr);
@@ -342,20 +308,6 @@ inparam_conversion(afs_int32 cmd, char *buffer, afs_int32 ntoh_conv)
 	else
 	    *lptr = htonl(*lptr);
 	break;
-    case VIOC_AFS_SYSNAME & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
-    case VIOC_EXPORTAFS & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOCGETAL & 0xffff:
     case VIOCGETVOLSTAT & 0xffff:
     case VIOCGETCACHEPARMS & 0xffff:
@@ -444,39 +396,10 @@ outparam_conversion(afs_int32 cmd, char *buffer, afs_int32 ntoh_conv)
 	lptr++;			/* primary flag */
 	break;
     case VIOCCKCONN & 0xffff:
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOC_AFS_MARINER_HOST & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOC_VENUSLOG & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOC_GETCELLSTATUS & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOC_AFS_SYSNAME & 0xffff:
-	lptr = (afs_int32 *) buffer;
-	if (ntoh_conv)
-	    *lptr = ntohl(*lptr);
-	else
-	    *lptr = htonl(*lptr);
-	break;
     case VIOC_EXPORTAFS & 0xffff:
 	lptr = (afs_int32 *) buffer;
 	if (ntoh_conv)