From: Jeffrey Altman <jaltman@your-file-system.com>
Date: Mon, 17 Oct 2011 13:22:53 +0000 (-0400)
Subject: Windows: AFSEvaluateTargetByName free buffer if no return
X-Git-Tag: upstream/1.8.0_pre1^2~3130
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=46a96ee06582178eb88e8ca1c7fbb33fae79b403;p=packages%2Fo%2Fopenafs.git

Windows: AFSEvaluateTargetByName free buffer if no return

For consistency with other functions in AFSCommSupport
modify AFSEvaluateTargetByName to free the DirEntry on
completion if the caller has not provided an out parameter
to accept it.

Change-Id: Ic5b6cc655fd47b95493e6aadb7b23481d0187d5c
Reviewed-on: http://gerrit.openafs.org/5624
Reviewed-by: Rod Widdowson <rdw@steadingsoftware.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
---

diff --git a/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp b/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp
index 8f5d334d5..3f05e8b93 100644
--- a/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp
+++ b/src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp
@@ -1638,7 +1638,16 @@ AFSEvaluateTargetByName( IN GUID *AuthGroup,
         // Pass back the dir enum entry
         //
 
-        *DirEnumEntry = pDirEnumCB;
+        if( DirEnumEntry != NULL)
+        {
+
+            *DirEnumEntry = pDirEnumCB;
+        }
+        else
+        {
+
+            AFSExFreePool( pDirEnumCB);
+        }
 
 try_exit: