From: Andrew Deason Date: Fri, 2 Dec 2011 20:36:59 +0000 (-0600) Subject: salvager: Create link table with volume group id X-Git-Tag: upstream/1.6.1.pre1^2~14 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=4b251f18a7af2868e2353131a3dbc6d73065e9f4;p=packages%2Fo%2Fopenafs.git salvager: Create link table with volume group id The link table needs to be created with the VG id or RW vol id, not the non-RW vol id. Unlike other special inodes, this goes for both the 'parent' and 'volume' volume ids, not just the 'parent' id, since there is only one link table per VG. Without this, the salvager can generate invalid linktable special inodes if it encounters a VG with no inodes for the RW vol. Reviewed-on: http://gerrit.openafs.org/6179 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit ae227049fca2519e1f5ae1e8b68efbff10ebb665) Change-Id: Ia8089cae6cb5ab97ef9d4ea306f3c48bead59914 Reviewed-on: http://gerrit.openafs.org/6325 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- diff --git a/src/vol/vol-salvage.c b/src/vol/vol-salvage.c index 87d586453..e21630c9e 100644 --- a/src/vol/vol-salvage.c +++ b/src/vol/vol-salvage.c @@ -1816,7 +1816,7 @@ CreateLinkTable(struct SalvInfo *salvinfo, struct InodeSummary *isp, Inode ino) if (!VALID_INO(ino)) ino = - IH_CREATE(NULL, salvinfo->fileSysDevice, salvinfo->fileSysPath, 0, isp->volumeId, + IH_CREATE(NULL, salvinfo->fileSysDevice, salvinfo->fileSysPath, 0, isp->RWvolumeId, INODESPECIAL, VI_LINKTABLE, isp->RWvolumeId); if (!VALID_INO(ino)) Abort