From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Thu, 7 Feb 2008 21:21:20 +0000 (+0000)
Subject: DEVEL15-windows-scache-refcount-race-20080207
X-Git-Tag: openafs-devel-1_5_31~13
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=4d8ed8defebf2045d99274ff18821f5eed54f63a;p=packages%2Fo%2Fopenafs.git

DEVEL15-windows-scache-refcount-race-20080207

LICENSE MIT

if we are going to call a NoLock function better be holding the lock


(cherry picked from commit bb2dc54732c865f37b0e9c5b928c850daa795b4d)
---

diff --git a/src/WINNT/afsd/cm_callback.c b/src/WINNT/afsd/cm_callback.c
index 96f6c36e1..0d2b00bb3 100644
--- a/src/WINNT/afsd/cm_callback.c
+++ b/src/WINNT/afsd/cm_callback.c
@@ -1932,8 +1932,8 @@ void cm_CheckCBExpiration(void)
                 lock_ReleaseMutex(&scp->mx);
                 cm_CallbackNotifyChange(scp);
 
-                cm_ReleaseSCacheNoLock(scp);
                 lock_ObtainWrite(&cm_scacheLock);
+                cm_ReleaseSCacheNoLock(scp);
             }
         }
     }