From: Benjamin Kaduk <kaduk@mit.edu>
Date: Fri, 10 Jan 2014 05:00:52 +0000 (-0500)
Subject: Use an explicit symbol for uninitialized vnode types
X-Git-Tag: upstream/1.8.0_pre1^2~830
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=51d31209dc9a3082461cc9430da0975fdf28b085;p=packages%2Fo%2Fopenafs.git

Use an explicit symbol for uninitialized vnode types

Avoid trying to get clever with stuffing -1 into an unsigned bitfield,
which causes the value to change and generates a warning from clang.
Just use vNull, which is intended to be used for uninitialized/empty
vnodes.

Change-Id: I5662887e5a68c7e687025d19226f821d8f2d6a09
Reviewed-on: http://gerrit.openafs.org/10701
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
---

diff --git a/src/tools/dumpscan/dumptool.c b/src/tools/dumpscan/dumptool.c
index be8d5750a..70b2ec708 100644
--- a/src/tools/dumpscan/dumptool.c
+++ b/src/tools/dumpscan/dumptool.c
@@ -918,7 +918,7 @@ ScanVnodes(FILE * f, VolumeDiskData * vol, int sizescan)
 
 	offset = 0;
 	length = 0;
-	vnode->type = -1;
+	vnode->type = vNull;
 	vnode->length = -1;
 
 	if (ReadInt32(f, (uint32_t *) & vnodeNumber)) {
@@ -1064,7 +1064,7 @@ ScanVnodes(FILE * f, VolumeDiskData * vol, int sizescan)
 	 * just skip it (because we can't do anything with it.
 	 */
 
-	if (vnode->type == -1)
+	if (vnode->type == vNull)
 	    continue;
 
 #ifdef RESIDENCY