From: Jim Rees Date: Thu, 15 May 2003 16:12:36 +0000 (+0000) Subject: STABLE12-pioctl-buffer-size-checking-20030515 X-Git-Tag: openafs-stable-1_2_10~81 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=52efa44ef90ccad67f0b35111025716d5ffd5376;p=packages%2Fo%2Fopenafs.git STABLE12-pioctl-buffer-size-checking-20030515 don't check output buffer size against PIGGY (cherry picked from commit 19b1a9015f5546881c3c077e4c39d2b8d167dfc5) --- diff --git a/src/afs/afs_pioctl.c b/src/afs/afs_pioctl.c index bbe233f0a..36e5a172d 100644 --- a/src/afs/afs_pioctl.c +++ b/src/afs/afs_pioctl.c @@ -1084,10 +1084,10 @@ afs_HandlePioctl(avc, acom, ablob, afollow, acred) return EINVAL; /* out of range */ } inSize = ablob->in_size; - + /* Do all range checking before continuing */ - if ((inSize >= PIGGYSIZE) || (inSize < 0)) return E2BIG; - if ((ablob->out_size >= PIGGYSIZE) || (ablob->out_size < 0)) return E2BIG; + if (inSize >= PIGGYSIZE || inSize < 0 || ablob->out_size < 0) + return E2BIG; inData = osi_AllocLargeSpace(AFS_LRALLOCSIZ); if (inSize > 0) {