From: Simon Wilkinson <sxw@your-file-system.com>
Date: Fri, 15 Feb 2013 16:35:08 +0000 (+0000)
Subject: rxgen: Remove pointless assignment
X-Git-Tag: upstream/1.8.0_pre1^2~1513
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=538f8d836376116edf99af17b040bc1aeea72390;p=packages%2Fo%2Fopenafs.git

rxgen: Remove pointless assignment

The value we assign to defp is never used (it's almost immediately
overwritten), and it is guaranteed to be the same as the existing
value. So, just remove the assignment.

Caught by clang-analyzer

Change-Id: I362fe08c623b5046f2c8b0b16c42dcfa12009981
Reviewed-on: http://gerrit.openafs.org/9162
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/rxgen/rpc_parse.c b/src/rxgen/rpc_parse.c
index 5aed967a1..b8bf6e127 100644
--- a/src/rxgen/rpc_parse.c
+++ b/src/rxgen/rpc_parse.c
@@ -2034,7 +2034,6 @@ er_ProcProcsArray_setup(void)
 			"\nstatic afs_int32 (*StubProcsArray%d[])(struct rx_call *z_call, XDR *z_xdrs) = {_%s%s%s",
 			PackageIndex, prefix, defp->pc.proc_prefix,
 			((definition *) listp->val)->pc.proc_name);
-		defp = (definition *) listp->val;
 	    }
 	}
 	listp = listp->next;