From: Simon Wilkinson <sxw@your-file-system.com>
Date: Mon, 25 Feb 2013 10:26:33 +0000 (+0000)
Subject: volser: Don't catch errors in cleanup
X-Git-Tag: upstream/1.8.0_pre1^2~1423
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=5474e1ccd77a3a40db3601f94556001610c82b95;p=packages%2Fo%2Fopenafs.git

volser: Don't catch errors in cleanup

We can't do anything if cleaning up the clone volume fails, so
don't bother storing the error code.

Caught by clang-analyzer

Change-Id: I5249dbad9a1bb732aba73e7a09f74c83e606b45d
Reviewed-on: http://gerrit.openafs.org/9258
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/volser/vsprocs.c b/src/volser/vsprocs.c
index a5147b032..7af0d9ffd 100644
--- a/src/volser/vsprocs.c
+++ b/src/volser/vsprocs.c
@@ -2578,8 +2578,8 @@ cpincr:
 
     /* common cleanup - delete local clone */
     if (cloneVol)
-	code = DoVolDelete(fromconn, cloneVol, afrompart,
-			   "clone", 0, NULL, "Recovery:");
+	DoVolDelete(fromconn, cloneVol, afrompart,
+		    "clone", 0, NULL, "Recovery:");
 
   done:			/* routine cleanup */
     if (fromconn)