From: Michael Meffie Date: Fri, 17 Apr 2015 00:03:21 +0000 (-0400) Subject: viced: add missing new lines to log messages X-Git-Tag: upstream/1.6.18^2~28 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=54a14d5349d19a7c765991552441ace97fe9bc21;p=packages%2Fo%2Fopenafs.git viced: add missing new lines to log messages The server logger requires an explicit new line. Reviewed-on: http://gerrit.openafs.org/11841 Tested-by: BuildBot Reviewed-by: Mark Vitale Reviewed-by: Benjamin Kaduk (cherry picked from commit 634ca4fdc206884afe0826bc682aa7d5208cdc8b) Change-Id: Ic04d98d15b92a86303a38000d5738c038b83d68f Reviewed-on: https://gerrit.openafs.org/12129 Tested-by: BuildBot Reviewed-by: Michael Meffie Reviewed-by: Mark Vitale Reviewed-by: Stephan Wiesand --- diff --git a/src/viced/afsfileprocs.c b/src/viced/afsfileprocs.c index 126203cf9..31add15b6 100644 --- a/src/viced/afsfileprocs.c +++ b/src/viced/afsfileprocs.c @@ -4407,7 +4407,7 @@ SAFSS_Rename(struct rx_call *acall, struct AFSFid *OldDirFid, char *OldName, NewName, errno)); if ((errno != ENOENT) && (errno != EIO) && (errno != ENXIO)) - ViceLog(0, ("Do we need to fsck?")); + ViceLog(0, ("Do we need to fsck?\n")); } } VN_SET_INO(newfileptr, (Inode) 0); diff --git a/src/viced/host.c b/src/viced/host.c index 803a6471c..e4501c691 100644 --- a/src/viced/host.c +++ b/src/viced/host.c @@ -284,20 +284,20 @@ hpr_Initialize(struct ubik_client **uclient) tdir = afsconf_Open(AFSDIR_SERVER_ETC_DIRPATH); if (!tdir) { - ViceLog(0, ("hpr_Initialize: Could not open configuration directory: %s", AFSDIR_SERVER_ETC_DIRPATH)); + ViceLog(0, ("hpr_Initialize: Could not open configuration directory: %s\n", AFSDIR_SERVER_ETC_DIRPATH)); return -1; } code = afsconf_GetLocalCell(tdir, cellstr, sizeof(cellstr)); if (code) { - ViceLog(0, ("hpr_Initialize: Could not get local cell. [%d]", code)); + ViceLog(0, ("hpr_Initialize: Could not get local cell. [%d]\n", code)); afsconf_Close(tdir); return code; } code = afsconf_GetCellInfo(tdir, cellstr, "afsprot", &info); if (code) { - ViceLog(0, ("hpr_Initialize: Could not locate cell %s in %s/%s", + ViceLog(0, ("hpr_Initialize: Could not locate cell %s in %s/%s\n", cellstr, tdir->name, AFSDIR_CELLSERVDB_FILE)); afsconf_Close(tdir); return code; @@ -305,7 +305,7 @@ hpr_Initialize(struct ubik_client **uclient) code = rx_Init(0); if (code) { - ViceLog(0, ("hpr_Initialize: Could not initialize rx.")); + ViceLog(0, ("hpr_Initialize: Could not initialize rx.\n")); afsconf_Close(tdir); return code; } @@ -315,14 +315,14 @@ hpr_Initialize(struct ubik_client **uclient) * specified. */ code = afsconf_ClientAuthSecure(tdir, &sc, &scIndex); if (code) - ViceLog(0, ("hpr_Initialize: clientauthsecure returns %d %s (so trying noauth)", code, afs_error_message(code))); + ViceLog(0, ("hpr_Initialize: clientauthsecure returns %d %s (so trying noauth)\n", code, afs_error_message(code))); if (code) scIndex = RX_SECIDX_NULL; if ((scIndex == RX_SECIDX_NULL) && (sc == NULL)) sc = rxnull_NewClientSecurityObject(); if (scIndex == RX_SECIDX_NULL) - ViceLog(0, ("hpr_Initialize: Could not get afs tokens, running unauthenticated. [%d]", code)); + ViceLog(0, ("hpr_Initialize: Could not get afs tokens, running unauthenticated. [%d]\n", code)); memset(serverconns, 0, sizeof(serverconns)); /* terminate list!!! */ for (i = 0; i < info.numServers; i++) { @@ -334,7 +334,7 @@ hpr_Initialize(struct ubik_client **uclient) code = ubik_ClientInit(serverconns, uclient); if (code) { - ViceLog(0, ("hpr_Initialize: ubik client init failed. [%d]", code)); + ViceLog(0, ("hpr_Initialize: ubik client init failed. [%d]\n", code)); } afsconf_Close(tdir); code = rxs_Release(sc); @@ -1402,7 +1402,7 @@ reconcileHosts_r(afs_uint32 addr, afs_uint16 port, struct host *newHost, ViceLog(125, ("reconcileHosts_r: addr %s:%d newHost %" AFS_PTR_FMT " oldHost %" - AFS_PTR_FMT, afs_inet_ntoa_r(addr, hoststr), ntohs(port), + AFS_PTR_FMT "\n", afs_inet_ntoa_r(addr, hoststr), ntohs(port), newHost, oldHost)); osi_Assert(oldHost != newHost);