From: Jeffrey Altman <jaltman@your-file-system.com>
Date: Thu, 16 May 2013 19:47:11 +0000 (-0400)
Subject: Windows: AFSNameArrayClone leak in AFSCommonCreate
X-Git-Tag: upstream/1.8.0_pre1^2~1158
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=594c97675fd961b347b451bd000804962df1b721;p=packages%2Fo%2Fopenafs.git

Windows: AFSNameArrayClone leak in AFSCommonCreate

Do not leak the AFSNameArrayClone if AFSLocateName fails.

Change-Id: I01ea5ac7261de2cd2e715e7d110cb5e09173938c
Reviewed-on: http://gerrit.openafs.org/9922
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp b/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp
index 648ad2948..ea10538f6 100644
--- a/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp
+++ b/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp
@@ -819,6 +819,13 @@ AFSCommonCreate( IN PDEVICE_OBJECT DeviceObject,
 						       &uniComponentName);
 		    }
 		}
+		else
+		{
+
+		    AFSFreeNameArray( pNameArrayClone);
+
+		    pNameArrayClone = NULL;
+		}
 
 		if ( pNewVolumeCB != NULL)
 		{