From: Jeffrey Altman <jaltman@auristor.com>
Date: Fri, 23 Feb 2018 23:47:46 +0000 (-0500)
Subject: rx: connection aborts send serial zero when no conn available
X-Git-Tag: upstream/1.8.1_pre2^2~75
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=5b9da66861db10dcc1d896769b495738cc07b450;p=packages%2Fo%2Fopenafs.git

rx: connection aborts send serial zero when no conn available

When no connection object is available, send serial number zero (0)
instead of one (1).  There is no harm in sending one (1) but it might
be confused as the first packet sent on the connection.  Multiple
connection aborts sent would all be sent with serial one (1).

Serial number zero (0) can be an indication to humans reading packet
traces that the sender has no knowledge of the connection.

Reviewed-on: https://gerrit.openafs.org/12932
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 09f31d4c21328bcdc1dccdedf7df53d77c22e3e3)

Change-Id: Ie5b8052903307be4bc932e57e45efae7dd75dec8
Reviewed-on: https://gerrit.openafs.org/13051
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/src/rx/rx.c b/src/rx/rx.c
index 698be10dc..e84cf32de 100644
--- a/src/rx/rx.c
+++ b/src/rx/rx.c
@@ -3425,7 +3425,7 @@ rxi_ReceivePacket(struct rx_packet *np, osi_socket socket,
        don't abort an abort. */
     if (!conn) {
         if (unknownService && (np->header.type != RX_PACKET_TYPE_ABORT))
-	    rxi_SendRawAbort(socket, host, port, 1, RX_INVALID_OPERATION,
+	    rxi_SendRawAbort(socket, host, port, 0, RX_INVALID_OPERATION,
                              np, 0);
         return np;
     }