From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 19 Feb 2013 17:11:50 +0000 (+0000)
Subject: afsio: Ignore return values from afscp_SetDefault*
X-Git-Tag: upstream/1.8.0_pre1^2~1493
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=5e859ff2c35735729a030e9297e296595f750e22;p=packages%2Fo%2Fopenafs.git

afsio: Ignore return values from afscp_SetDefault*

We don't do anything with the return values from afscp_SetDefaultCell
or afscp_SetDefaultRealm, so just ignore them.

Caught by clang-analyzer

Change-Id: Ib7d9e637e5d08df28ad0085302811b243fb21768
Reviewed-on: http://gerrit.openafs.org/9188
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
---

diff --git a/src/venus/afsio.c b/src/venus/afsio.c
index 8c98707ad..99aea3946 100644
--- a/src/venus/afsio.c
+++ b/src/venus/afsio.c
@@ -674,10 +674,10 @@ lockFile(struct cmd_syndesc *as, void *arock)
 	locktype = LockRead;
 
     if (realm != NULL)
-	code = afscp_SetDefaultRealm(realm);
+	afscp_SetDefaultRealm(realm);
 
     if (cell != NULL)
-	code = afscp_SetDefaultCell(cell);
+	afscp_SetDefaultCell(cell);
 
     if (useFid)
 	code = GetVenusFidByFid(fname, cell, 0, &avfp);
@@ -763,10 +763,10 @@ readFile(struct cmd_syndesc *as, void *unused)
 	MD5_Init(&md5);
 
     if (realm != NULL)
-	code = afscp_SetDefaultRealm(realm);
+	afscp_SetDefaultRealm(realm);
 
     if (cell != NULL)
-	code = afscp_SetDefaultCell(cell);
+	afscp_SetDefaultCell(cell);
 
     if (useFid)
 	code = GetVenusFidByFid(fname, cell, 0, &avfp);
@@ -880,10 +880,10 @@ writeFile(struct cmd_syndesc *as, void *unused)
 	afscp_Insecure();
 
     if (realm != NULL)
-	code = afscp_SetDefaultRealm(realm);
+	afscp_SetDefaultRealm(realm);
 
     if (cell != NULL)
-	code = afscp_SetDefaultCell(cell);
+	afscp_SetDefaultCell(cell);
 
     if (sSynthLen) {
 	code = util_GetInt64(sSynthLen, &synthlength);