From: Marc Dionne <marc.c.dionne@gmail.com>
Date: Thu, 4 Feb 2010 02:34:24 +0000 (-0500)
Subject: Don't clear afs_stats_cmperf too early during shutdown
X-Git-Tag: openafs-devel-1_5_72~44
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=604471a3f881a7895cda218a823692a63044dd2e;p=packages%2Fo%2Fopenafs.git

Don't clear afs_stats_cmperf too early during shutdown

Commit 21cbf7fee0a089d94f62baa7df2422e7bc8293f7 activated some
previously unused cleanup code.  Part of this clears afs_stats_cmperf,
but these stats are used later to check for leaks of chunks allocated
with afs_AllocSmallSpace and afs_AllocLargeSpace.  The result is a
message about unfreed blocks in the syslog with negative counts.

Since the structure is already cleared later in the shutdown process,
just remove this instance.

Change-Id: I6bf2ab37752d2623d072469fb87fa6d06e85b9ec
Reviewed-on: http://gerrit.openafs.org/1229
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
---

diff --git a/src/afs/afs_init.c b/src/afs/afs_init.c
index 8e511cb0a..a0dde1b14 100644
--- a/src/afs/afs_init.c
+++ b/src/afs/afs_init.c
@@ -712,7 +712,6 @@ shutdown_cache(void)
 	cacheInfoModTime = 0;
 
 	afs_fsfragsize = 1023;
-	memset(&afs_stats_cmperf, 0, sizeof(afs_stats_cmperf));
 	memset(&cacheDev, 0, sizeof(struct osi_dev));
 	osi_dnlc_shutdown();
     }