From: Rainer Toebbicke <rtb@pclella.cern.ch>
Date: Wed, 8 Aug 2007 16:54:39 +0000 (+0000)
Subject: STABLE14-viced-multi-probe-addr-20070808
X-Git-Tag: openafs-stable-1_4_5-pre1~40
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=63bf2d2cedbdced75173b5de6ae65622cab5878d;p=packages%2Fo%2Fopenafs.git

STABLE14-viced-multi-probe-addr-20070808

FIXES 67355

MultiProbeAlternateAddress_r badly indexes the list of interfaces for
clients with multiple IP interfaces, resulting in peers with IP
address 0 port 0 to be created. This in turn results in rxi_sendmsg
errors (on systems where caught early, as on Linux, on others it may
pass unnoticed).


(cherry picked from commit f099df38b2eff9c8c5afb52ec1a69dd89af22dad)
---

diff --git a/src/viced/callback.c b/src/viced/callback.c
index 9ba55f4ce..1a4fdbd53 100644
--- a/src/viced/callback.c
+++ b/src/viced/callback.c
@@ -2161,8 +2161,8 @@ MultiProbeAlternateAddress_r(struct host *host)
 
 	interfaces[j] = host->interface->interface[i];
 	conns[j] =
-	    rx_NewConnection(interfaces[i].addr, 
-			     interfaces[i].port, 1, sc, 0);
+	    rx_NewConnection(interfaces[j].addr, 
+			     interfaces[j].port, 1, sc, 0);
 	rx_SetConnDeadTime(conns[j], 2);
 	rx_SetConnHardDeadTime(conns[j], AFS_HARDDEADTIME);
 	j++;