From: Simon Wilkinson Date: Wed, 20 Feb 2013 11:18:28 +0000 (+0000) Subject: volser: Fix a couple of assigned but not read errors X-Git-Tag: upstream/1.8.0_pre1^2~1454 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=63d1b17c255e6287e6b2cda3c28b2f5824bec345;p=packages%2Fo%2Fopenafs.git volser: Fix a couple of assigned but not read errors Fix a couple more errors where we assign to a variable, but never read the result back out. Caught by clang-analyzer Change-Id: I78f8f1403d166c4231b0abdb607de77e9ed62a27 Reviewed-on: http://gerrit.openafs.org/9201 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- diff --git a/src/volser/vsprocs.c b/src/volser/vsprocs.c index 39e50eb3e..ca88c675d 100644 --- a/src/volser/vsprocs.c +++ b/src/volser/vsprocs.c @@ -1513,7 +1513,7 @@ UV_MoveVolume2(afs_uint32 afromvol, afs_uint32 afromserver, afs_int32 afrompart, pntg = 1; toconn = UV_Bind(atoserver, AFSCONF_VOLUMEPORT); /* get connections to the servers */ fromconn = UV_Bind(afromserver, AFSCONF_VOLUMEPORT); - fromtid = totid = 0; /* initialize to uncreated */ + totid = 0; /* initialize to uncreated */ /* *** * clone the read/write volume locally. @@ -2084,7 +2084,6 @@ UV_MoveVolume2(afs_uint32 afromvol, afs_uint32 afromserver, afs_int32 afrompart, ubik_VL_ReleaseLock(cstruct, 0, afromvol, -1, (LOCKREL_OPCODE | LOCKREL_AFSID | LOCKREL_TIMESTAMP)); VDONE; - islocked = 0; } done: /* routine cleanup */ if (volName)