From: Simon Wilkinson <sxw@your-file-system.com>
Date: Sun, 27 Mar 2011 22:03:00 +0000 (+0100)
Subject: uss: Tidy up header includes
X-Git-Tag: upstream/1.8.0_pre1^2~3917
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=6465e4243c6398f60dff3037e27119bb067c5038;p=packages%2Fo%2Fopenafs.git

uss: Tidy up header includes

Remove headers which are provided by libroken, and reorder header
includes so that they're a bit a more legible.

Change-Id: I1d729adfd0a4cbe73b68e553ec122073a737c8a5
Reviewed-on: http://gerrit.openafs.org/4414
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
---

diff --git a/src/uss/uss.c b/src/uss/uss.c
index b1bfee0fa..b1463a861 100644
--- a/src/uss/uss.c
+++ b/src/uss/uss.c
@@ -14,16 +14,17 @@
 /*
  * --------------------- Required definitions ---------------------
  */
-#include <stdlib.h>
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
 
-#ifdef	AFS_AIX32_ENV
-#include <signal.h>
-#endif
-
-#include <string.h>
+#include <afs/cmd.h>		/*Command line parsing */
+#include <afs/cellconfig.h>	/*Cell config defs */
+#include <afs/kautils.h>	/*MAXKTCREALMLEN & MAXKTCNAMELEN */
+#include <afs/pterror.h>
+#include <afs/vlserver.h>
+#include <ubik.h>
 
 #include "uss_common.h"		/*Common uss definitions, globals */
 #include "uss_procs.h"		/*Main uss operations */
@@ -32,12 +33,6 @@
 #include "uss_ptserver.h"
 #include "uss_vol.h"
 #include "uss_acl.h"
-#include <afs/cmd.h>		/*Command line parsing */
-#include <afs/cellconfig.h>	/*Cell config defs */
-#include <afs/kautils.h>	/*MAXKTCREALMLEN & MAXKTCNAMELEN */
-#include <afs/pterror.h>
-#include <afs/vlserver.h>
-#include <ubik.h>
 
 extern int yylex(void);
 extern int yyparse (void);
diff --git a/src/uss/uss_acl.c b/src/uss/uss_acl.c
index 9ed9aebe4..f14561fe0 100644
--- a/src/uss/uss_acl.c
+++ b/src/uss/uss_acl.c
@@ -18,17 +18,7 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-
-#include "uss_acl.h"
-#include "uss_common.h"
-#include "uss_fs.h"
-#include <rx/xdr.h>
-#include <sys/socket.h>
-#include <sys/types.h>
-#include <netdb.h>
-#include <errno.h>
-
-#include <string.h>
+#include <roken.h>
 
 #undef VIRTUE
 #undef VICE
@@ -36,6 +26,11 @@
 #include <afs/prs_fs.h>
 #include <afs/com_err.h>
 #include <afs/afs_consts.h>
+#include <rx/xdr.h>
+
+#include "uss_acl.h"
+#include "uss_common.h"
+#include "uss_fs.h"
 
 #define MAXNAME 100
 
diff --git a/src/uss/uss_common.c b/src/uss/uss_common.c
index afaab191d..d547b47b7 100644
--- a/src/uss/uss_common.c
+++ b/src/uss/uss_common.c
@@ -18,12 +18,11 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
 
-#include "uss_common.h"		/*Interface definitions */
 #include <afs/kautils.h>	/*MAXKTCREALMLEN & MAXKTCNAMELEN */
 
-#include <string.h>
-
+#include "uss_common.h"		/*Interface definitions */
 
 /*
  * ---------------------- Exported variables ----------------------
diff --git a/src/uss/uss_fs.c b/src/uss/uss_fs.c
index 2030a928c..77cdb2bf1 100644
--- a/src/uss/uss_fs.c
+++ b/src/uss/uss_fs.c
@@ -18,24 +18,18 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
 
-#include "uss_fs.h"		/*Interface to this module */
-#include <sys/types.h>
-#include <errno.h>
-#include <sys/socket.h>
 #ifdef	AFS_SUN5_ENV
 #include <sys/ioccom.h>
 #endif
-#include <netinet/in.h>
-
-#include <string.h>
-#include <unistd.h>
 
 #include <afs/venus.h>
 #include <rx/rx.h>
 #include <afs/sys_prototypes.h>
-#include "uss_common.h"
 
+#include "uss_common.h"
+#include "uss_fs.h"		/*Interface to this module */
 
 /*
  * ---------------------- Private definitions ---------------------
diff --git a/src/uss/uss_kauth.c b/src/uss/uss_kauth.c
index c077c9eda..da956bd94 100644
--- a/src/uss/uss_kauth.c
+++ b/src/uss/uss_kauth.c
@@ -18,18 +18,16 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-
-#include "uss_kauth.h"		/*Module interface */
-#include "uss_common.h"		/*Common defs & operations */
-#include <errno.h>
-#include <pwd.h>
-
-#include <string.h>
+#include <roken.h>
 
 #include <afs/com_err.h>
 #include <afs/kautils.h> /*MAXKTCREALMLEN*/
 #include <afs/kaport.h>		/* pack_long */
 #include <afs/kauth.h>
+
+#include "uss_kauth.h"		/*Module interface */
+#include "uss_common.h"		/*Common defs & operations */
+
 #define uss_kauth_MAX_SIZE	2048
 #undef USS_KAUTH_DB
 /*
diff --git a/src/uss/uss_procs.c b/src/uss/uss_procs.c
index 225fee946..a5be915c0 100644
--- a/src/uss/uss_procs.c
+++ b/src/uss/uss_procs.c
@@ -18,23 +18,14 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
+
+#include <afs/kautils.h> /*MAXKTCREALMLEN*/
 
 #include "uss_procs.h"		/*Module interface */
 #include "uss_common.h"		/*Common defs & operations */
 #include "uss_acl.h"		/*ACL-related operations */
-#include <errno.h>		/*Unix error codes */
-#include <pwd.h>		/*Password info */
-#include <sys/stat.h>		/*Stat defs */
-#include <dirent.h>		/*Directory package */
-#include <sys/file.h>		/*O_EXCL, O_CREAT, etc */
-#ifdef	AFS_SUN5_ENV
-#include <fcntl.h>
-#endif
-
-#include <string.h>
-#include <stdarg.h>
 
-#include <afs/kautils.h> /*MAXKTCREALMLEN*/
 #undef USS_PROCS_DB
 #undef USS_PROCS_DB_INSTANCE
 #undef USS_PROCS_DB_BUILDDIR
diff --git a/src/uss/uss_ptserver.c b/src/uss/uss_ptserver.c
index 31b0d3dc5..68a493224 100644
--- a/src/uss/uss_ptserver.c
+++ b/src/uss/uss_ptserver.c
@@ -18,13 +18,14 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
 
-#include "uss_ptserver.h"	/*Module interface */
 #include <afs/ptclient.h>	/*Protection Server client interface */
 #include <afs/pterror.h>	/*Protection Server error codes */
 #include <afs/ptuser.h>
 #include <afs/com_err.h>	/*Error code xlation */
 
+#include "uss_ptserver.h"	/*Module interface */
 
 #undef USS_PTSERVER_DB
 
diff --git a/src/uss/uss_vol.c b/src/uss/uss_vol.c
index 3090c7c31..3a5f3f73c 100644
--- a/src/uss/uss_vol.c
+++ b/src/uss/uss_vol.c
@@ -18,18 +18,7 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-
-#include "uss_vol.h"		/*Interface to this module */
-#include "uss_common.h"		/*Common definitions */
-#include "uss_procs.h"		/*Defs from procs module */
-#include "uss_fs.h"		/*CacheManager ops */
-#include "uss_acl.h"
-#include <sys/stat.h>
-#include <pwd.h>
-#include <netdb.h>
-#include <errno.h>
-
-#include <string.h>
+#include <roken.h>
 
 #include <afs/com_err.h>
 #include <afs/vlserver.h>
@@ -44,6 +33,12 @@
 #include <afs/afsutil.h>
 #include <ubik.h>
 
+#include "uss_vol.h"		/*Interface to this module */
+#include "uss_common.h"		/*Common definitions */
+#include "uss_procs.h"		/*Defs from procs module */
+#include "uss_fs.h"		/*CacheManager ops */
+#include "uss_acl.h"
+
 extern int line;
 
 /*