From: Benjamin Kaduk <kaduk@mit.edu>
Date: Thu, 16 Nov 2017 10:48:02 +0000 (-0600)
Subject: rx: fix mutex leak in error case
X-Git-Tag: upstream/1.8.0_pre3^2~9
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=667617b8702e797e34cc957ef200a803030ee901;p=packages%2Fo%2Fopenafs.git

rx: fix mutex leak in error case

Reported by Mark Vitale

Reviewed-on: https://gerrit.openafs.org/12771
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 01bcfd3e14f6ee1faa4b8ce5a7932de37d585fd3)

Change-Id: I4384d6813a5cfb053e6991eb3c157fa59ecfa11b
Reviewed-on: https://gerrit.openafs.org/12777
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
---

diff --git a/src/rx/rx.c b/src/rx/rx.c
index d25acef79..95e88c291 100644
--- a/src/rx/rx.c
+++ b/src/rx/rx.c
@@ -1248,6 +1248,7 @@ rxi_DestroyConnectionNoLock(struct rx_connection *conn)
     if ((conn->type == RX_CLIENT_CONNECTION)
 	&& (conn->flags & (RX_CONN_MAKECALL_WAITING|RX_CONN_MAKECALL_ACTIVE))) {
 	conn->flags |= RX_CONN_DESTROY_ME;
+	MUTEX_EXIT(&rx_refcnt_mutex);
 	MUTEX_EXIT(&conn->conn_data_lock);
 	USERPRI;
 	return;