From: Perry Ruiter <pruiter@sinenomine.net>
Date: Fri, 30 May 2014 02:24:24 +0000 (-0700)
Subject: afs: Delete unneeded duplicate code
X-Git-Tag: upstream/1.8.0_pre1^2~659
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=69705782318226806b6a2b092ec4b63d594d184c;p=packages%2Fo%2Fopenafs.git

afs: Delete unneeded duplicate code

Delete a memory release and a goto since natural code flow will
result in exactly the same thing.

Change-Id: I8fe1400aa2db0e15cbbd577ba18cc1fcdec18447
Reviewed-on: http://gerrit.openafs.org/11179
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: D Brashear <shadow@your-file-system.com>
---

diff --git a/src/afs/afs_call.c b/src/afs/afs_call.c
index cdafe0f59..4e3c4c43e 100644
--- a/src/afs/afs_call.c
+++ b/src/afs/afs_call.c
@@ -1054,10 +1054,6 @@ afs_syscall_call(long parm, long parm2, long parm3,
 	code = 0;
 	AFS_COPYINSTR(AFSKPTR(parm2), tbuffer, AFS_SMALLOCSIZ, &bufferSize,
 		      code);
-	if (code) {
-	    osi_FreeSmallSpace(tbuffer);
-	    goto out;
-	}
 	if (!code) {
 	    tbuffer[AFS_SMALLOCSIZ - 1] = '\0';	/* null-terminate the name */
 	    /* We have the cache dir copied in.  Call the cache init routine */