From: Simon Wilkinson Date: Fri, 5 Nov 2010 00:23:23 +0000 (+0000) Subject: rx: Don't maintain maxSerial X-Git-Tag: upstream/1.8.0_pre1^2~3647 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=6a22a2f4b7aa0d960cea17b419003986f6184d58;p=packages%2Fo%2Fopenafs.git rx: Don't maintain maxSerial There were no users within the code of the rx connection maxSerial element, and maintaining it required locking on a critical path. So, get rid of it. Change-Id: Ied5653b6f01b78525091d8bf09bdc454002eedc0 Reviewed-on: http://gerrit.openafs.org/4797 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman --- diff --git a/src/rx/rx.c b/src/rx/rx.c index b3a6f5a26..89e6df12d 100644 --- a/src/rx/rx.c +++ b/src/rx/rx.c @@ -2994,11 +2994,6 @@ rxi_ReceivePacket(struct rx_packet *np, osi_socket socket, return np; } - MUTEX_ENTER(&conn->conn_data_lock); - if (conn->maxSerial < np->header.serial) - conn->maxSerial = np->header.serial; - MUTEX_EXIT(&conn->conn_data_lock); - /* If the connection is in an error state, send an abort packet and ignore * the incoming packet */ if (conn->error) { diff --git a/src/rx/rx.h b/src/rx/rx.h index ec2a83343..48e8e3ad7 100644 --- a/src/rx/rx.h +++ b/src/rx/rx.h @@ -246,7 +246,6 @@ struct rx_connection { * call slot, or 0 if the slot is not busy */ afs_uint32 serial; /* Next outgoing packet serial number */ afs_uint32 lastSerial; /* # of last packet received, for computing skew */ - afs_int32 maxSerial; /* largest serial number seen on incoming packets */ afs_int32 lastPacketSize; /* last >max attempt */ afs_int32 lastPacketSizeSeq; /* seq number of attempt */ afs_int32 lastPingSize; /* last MTU ping attempt */