From: Jeffrey Altman <jaltman@your-file-system.com>
Date: Sun, 15 Apr 2012 21:40:03 +0000 (-0400)
Subject: rx: conn_call_lock leak
X-Git-Tag: upstream/1.8.0_pre1^2~2523
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=6a9b0d8c56ab80bdcc8d4e2d0b28a606837141cc;p=packages%2Fo%2Fopenafs.git

rx: conn_call_lock leak

In rxi_ReceivePacket, if the packet is for a client connection
and there is no call allocated, the conn->conn_call_lock was
leaked.  Introduced by 95c38dff3740d7e24971ceb5875c06e7abfce102.

Change-Id: Icfc10849c1da08d7c96d139b0a10d9ffe7ee57df
Reviewed-on: http://gerrit.openafs.org/7218
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
---

diff --git a/src/rx/rx.c b/src/rx/rx.c
index 79ee76a60..77de74dda 100644
--- a/src/rx/rx.c
+++ b/src/rx/rx.c
@@ -3334,6 +3334,7 @@ rxi_ReceivePacket(struct rx_packet *np, osi_socket socket,
          * then, since this is a client connection we're getting data for
          * it must be for the previous call.
          */
+        MUTEX_EXIT(&conn->conn_call_lock);
         if (rx_stats_active)
             rx_atomic_inc(&rx_stats.spuriousPacketsRead);
 	putConnection(conn);