From: Simon Wilkinson <sxw@your-file-system.com>
Date: Fri, 30 Mar 2012 18:40:30 +0000 (+0100)
Subject: xdr: Len can never be negative
X-Git-Tag: upstream/1.6.8^2~76
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=71e3c5d6ca4e1d75504249693fe9f4587c870487;p=packages%2Fo%2Fopenafs.git

xdr: Len can never be negative

The len parameter to xdr_len is unsigned, so can never be negative.
Don't bother testing to see if it is negative, so that clang likes us
again.

Reviewed-on: http://gerrit.openafs.org/7089
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit f1842bcb87c84e8862ca521f491215e42ce1ee2a)

Change-Id: I1cf030b8e9f79bdf867bcaecfd59d8ade7fc8c25
Reviewed-on: http://gerrit.openafs.org/10734
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
---

diff --git a/src/rx/xdr_mem.c b/src/rx/xdr_mem.c
index 0dd5daa0c..558b4dbf8 100644
--- a/src/rx/xdr_mem.c
+++ b/src/rx/xdr_mem.c
@@ -189,7 +189,7 @@ xdrmem_inline(XDR *xdrs, u_int len)
 {
     afs_int32 *buf = 0;
 
-    if (len >= 0 && xdrs->x_handy >= len) {
+    if (xdrs->x_handy >= len) {
 	xdrs->x_handy -= len;
 	buf = (afs_int32 *) xdrs->x_private;
 	xdrs->x_private += len;