From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Tue, 9 May 2006 02:34:20 +0000 (+0000)
Subject: windows-smb-vcp-clean-20060508
X-Git-Tag: BP-openafs-windows-kdfs-ifs~1310
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=77fbc6a158a570f1816c87433c0e4c44c0fc8fce;p=packages%2Fo%2Fopenafs.git

windows-smb-vcp-clean-20060508


don't grab the vcp mutex after releasing the vcp
---

diff --git a/src/WINNT/afsd/smb.c b/src/WINNT/afsd/smb.c
index f7bbba180..9ae605277 100644
--- a/src/WINNT/afsd/smb.c
+++ b/src/WINNT/afsd/smb.c
@@ -1095,15 +1095,15 @@ void smb_CleanupDeadVC(smb_vc_t *vcp)
 	uidpNext = vcp->usersp;
     }
 
+    lock_ObtainMutex(&vcp->mx);
+    vcp->flags &= ~SMB_VCFLAG_CLEAN_IN_PROGRESS;
+    lock_ReleaseMutex(&vcp->mx);
 
     /* The vcp is now on the deadVCsp list.  We intentionally drop the
      * reference so that the refcount can reach 0 and we can delete it */
     smb_ReleaseVCNoLock(vcp);
     
     lock_ReleaseWrite(&smb_rctLock);
-    lock_ObtainMutex(&vcp->mx);
-    vcp->flags &= ~SMB_VCFLAG_CLEAN_IN_PROGRESS;
-    lock_ReleaseMutex(&vcp->mx);
     osi_Log1(smb_logp, "Finished cleaning up dead vcp 0x%x", vcp);
 }