From: Jeffrey Altman <jaltman@your-file-system.com>
Date: Thu, 7 Jul 2011 21:51:58 +0000 (-0400)
Subject: Windows: cm_BkgDaemon should not do cm_SyncOp's job
X-Git-Tag: upstream/1.8.0_pre1^2~3459
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=7e3615208d9e1b03d8eba4fb802744b2b81f8868;p=packages%2Fo%2Fopenafs.git

Windows: cm_BkgDaemon should not do cm_SyncOp's job

cm_SyncOp is designed to synchronize operations among multiple
threads.  The background daemon threads should not filter requests
based upon cm_SyncOp states.  Doing so is racy and does not produce
better performance.

Change-Id: Ifeafd55da6e02807ed4cc3c3f2b6f1de4df2a87f
Reviewed-on: http://gerrit.openafs.org/5119
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
---

diff --git a/src/WINNT/afsd/cm_daemon.c b/src/WINNT/afsd/cm_daemon.c
index 6de9b0cad..d05385d22 100644
--- a/src/WINNT/afsd/cm_daemon.c
+++ b/src/WINNT/afsd/cm_daemon.c
@@ -118,8 +118,7 @@ void cm_BkgDaemon(void * parm)
         /* we found a request */
         for (rp = cm_bkgListEndp; rp; rp = (cm_bkgRequest_t *) osi_QPrev(&rp->q))
 	{
-	    if (!(rp->scp->flags & CM_SCACHEFLAG_DATASTORING) &&
-                cm_ServerAvailable(&rp->scp->fid, rp->userp))
+	    if (cm_ServerAvailable(&rp->scp->fid, rp->userp))
 		break;
 	}
 	if (rp == NULL) {