From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Sun, 2 Oct 2005 15:47:20 +0000 (+0000)
Subject: STABLE14-windows-shell-ext-prevent-unload-hack-20051002
X-Git-Tag: openafs-stable-1_4_0-rc6~11
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=7e969d3fb58b44a531f606422bc3409c9c033bc3;p=packages%2Fo%2Fopenafs.git

STABLE14-windows-shell-ext-prevent-unload-hack-20051002


The shell extension is unloading as it should but is never being loaded
again.  Since we have no clue why and no idea how to debug it, for now,
just prevent it from being unloaded in the first place.


(cherry picked from commit f8bdf475e2260f8c8d70a4ddc053ef3ec086a416)
---

diff --git a/src/WINNT/client_exp/afs_shl_ext.cpp b/src/WINNT/client_exp/afs_shl_ext.cpp
index 6c4d9c811..bc4d09e20 100644
--- a/src/WINNT/client_exp/afs_shl_ext.cpp
+++ b/src/WINNT/client_exp/afs_shl_ext.cpp
@@ -84,9 +84,16 @@ STDAPI DllCanUnloadNow(void)
 {
 	AFX_MANAGE_STATE(AfxGetStaticModuleState());
 
+#ifdef COMMENT
+    // This test is correct and we really do want to allow the extension to be loaded and 
+    // unloaded as needed.   Unfortunately, the extension is being unloaded and never loaded
+    // again which is disconcerting for many folks.  For now we will prevent the unloading 
+    // until someone has time to figure out how to debug this.   
+    // Jeffrey Altman - 2 Oct 2005
+
 	if (!nCMRefCount && !nSERefCount && !nICRefCount && !nTPRefCount && !nXPRefCount)
 		return S_OK;
-
+#endif
 	return S_FALSE;
 }