From: Marc Dionne <marc.c.dionne@gmail.com>
Date: Thu, 21 Jan 2010 02:03:08 +0000 (-0500)
Subject: Warning cleanup: implicit function declarations in butc and bucoord
X-Git-Tag: openafs-devel-1_5_70~16
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=7f1046896ee14d3e7ee6975e70cd1a9bb9f24736;p=packages%2Fo%2Fopenafs.git

Warning cleanup: implicit function declarations in butc and bucoord

Cleanup some prototype related warnings under bucoord and butc:
- Copy a few prototypes from bucoord_internal.h to bucoord_prototypes.h,
since they are used in other source directories
- Install bc.h under include/afs, and include it in tcmain.c
- Include bucoord_prototypes.h in tcmain.c
- Add a prototype for GetResponseKey
- Remove warning inhibition for tcmain.c, and entry in README.WARNINGS
- Remove warning inhibition for bucoord/dump.c (no entry in README)

Change-Id: I0a0ae92d3c7ba75e4a331bf59ea9c031763cc704
Reviewed-on: http://gerrit.openafs.org/1134
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
---

diff --git a/README.WARNINGS b/README.WARNINGS
index 923d89cec..045c43d49 100644
--- a/README.WARNINGS
+++ b/README.WARNINGS
@@ -49,7 +49,6 @@ bozo/bosserver.c     : deprecated    : daemon() marked as deprecated on Darwin
 bucoord/ubik_db_if.c : strict-proto  : Ubik_Call
 bucoord/commands.c   : all	     : Ubik_Call
 				     : signed vs unsigned for dates
-butc/tcmain.c	     : all	     : prototypes
 butc/tcudbprocs.c    : all	     : ubik_Call
 kauth/admin_tools.c  : all           : ubik_Call nonsense
 kauth/authclient.c   : strict-proto  : ubik_Call nonsense
diff --git a/src/bucoord/Makefile.in b/src/bucoord/Makefile.in
index 76ab79056..49aa84048 100644
--- a/src/bucoord/Makefile.in
+++ b/src/bucoord/Makefile.in
@@ -22,7 +22,7 @@ LIBS=${TOP_LIBDIR}/libbudb.a ${TOP_LIBDIR}/libbubasics.a \
         ${TOP_LIBDIR}/liblwp.a ${TOP_LIBDIR}/libcmd.a \
         ${TOP_LIBDIR}/libcom_err.a ${TOP_LIBDIR}/util.a
 
-all: ${TOP_LIBDIR}/libbxdb.a ${TOP_INCDIR}/afs/bucoord_prototypes.h backup
+all: ${TOP_LIBDIR}/libbxdb.a ${TOP_INCDIR}/afs/bucoord_prototypes.h ${TOP_INCDIR}/afs/bc.h backup
 
 ${TOP_LIBDIR}/libbxdb.a: libbxdb.a
 	${INSTALL_DATA} $? $@
@@ -30,6 +30,9 @@ ${TOP_LIBDIR}/libbxdb.a: libbxdb.a
 ${TOP_INCDIR}/afs/bucoord_prototypes.h: bucoord_prototypes.h
 	${INSTALL_DATA} $? $@
 
+${TOP_INCDIR}/afs/bc.h: bc.h
+	${INSTALL_DATA} $? $@
+
 libbxdb.a: dsstub.o ubik_db_if.o status.o dlq.o bucoord_errs.o volstub.o AFS_component_version_number.o
 	-$(RM) -f $@
 	$(AR) crv $@ dsstub.o ubik_db_if.o status.o dlq.o bucoord_errs.o volstub.o AFS_component_version_number.o
diff --git a/src/bucoord/bucoord_prototypes.h b/src/bucoord/bucoord_prototypes.h
index d36a73036..52d3ccf89 100644
--- a/src/bucoord/bucoord_prototypes.h
+++ b/src/bucoord/bucoord_prototypes.h
@@ -19,6 +19,7 @@ extern int dlqLinkf(dlqlinkP, dlqlinkP);
 extern int dlqTraverseQueue(dlqlinkP, int (*)(void *), int (*)(void *));
 
 /* status.c */
+extern void initStatus(void);
 extern statusP findStatus(afs_uint32);
 extern void lock_Status(void);
 extern void unlock_Status(void);
@@ -53,5 +54,10 @@ extern int bcdb_FindTapeSeq(afs_int32 dumpid, afs_int32 tapeSeq,
 extern afs_int32 bcdb_AddVolume(register struct budb_volumeEntry *);
 extern afs_int32 bcdb_AddVolumes(register struct budb_volumeEntry *,
 				 afs_int32 );
+extern afs_int32 udbClientInit(int noAuthFlag, int localauth, char *cellName);
+struct ktc_token;
+extern int vldbClientInit(int noAuthFlag, int localauth, char *cellName,
+                          struct ubik_client **cstruct,
+                          struct ktc_token *ttoken);
 #endif
 
diff --git a/src/butc/Makefile.in b/src/butc/Makefile.in
index 025caf5e6..09eb942fb 100644
--- a/src/butc/Makefile.in
+++ b/src/butc/Makefile.in
@@ -68,7 +68,7 @@ butc: ${SOBJS} ${LIBS} ${INCLS} ${HACKS}
 	esac
 
 tcmain.o: tcmain.c ${INCLS} AFS_component_version_number.c
-	$(CC) $(CFLAGS) @CFLAGS_NOERROR@ -c $<
+	$(CC) $(CFLAGS) -c $<
 dbentries.o: dbentries.c ${INCLS}
 tcprocs.o: tcprocs.c ${INCLS}
 test.o: test.c ${INCLS} AFS_component_version_number.c
@@ -79,7 +79,7 @@ recoverDb.o: recoverDb.c ${INCLS}
 tcudbprocs.o: tcudbprocs.c ${INCLS}
 	$(CC) $(CFLAGS) @CFLAGS_NOERROR@ -c $<
 dump.o: dump.c ${INCLS}
-	$(CC) $(CFLAGS) @CFLAGS_NOERROR@ -c $<
+	$(CC) $(CFLAGS) -c $<
 tcstatus.o: tcstatus.c ${INCLS}
 
 read_tape: read_tape.c
diff --git a/src/butc/butc_internal.h b/src/butc/butc_internal.h
index 46c4a17e2..a0f624374 100644
--- a/src/butc/butc_internal.h
+++ b/src/butc/butc_internal.h
@@ -38,6 +38,7 @@ extern int FindVolTrailer(char *, afs_int32, afs_int32 *,
 			  struct volumeHeader *);
 extern int FindVolTrailer2(char *, afs_int32, afs_int32 *, char *, afs_int32,
 			   afs_int32 *, struct volumeHeader *);
+extern int GetResponseKey(int, char *);
 
 
 /* recoverDb.c */
diff --git a/src/butc/tcmain.c b/src/butc/tcmain.c
index 87672bf40..884671139 100644
--- a/src/butc/tcmain.c
+++ b/src/butc/tcmain.c
@@ -60,6 +60,8 @@
 #define XBSA_TCMAIN
 #include "butc_xbsa.h"
 #include "butc_prototypes.h"
+#include <afs/kautils.h>
+#include <afs/bc.h>
 
 #define N_SECURITY_OBJECTS 3
 #define ERRCODE_RANGE 8		/* from error_table.h */