From: Andrew Deason Date: Tue, 13 Oct 2009 16:20:51 +0000 (-0500) Subject: Remove extra arguments to afs_syscall_call X-Git-Tag: openafs-stable-1_4_12pre1~121 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=7f59eb93f09eff525f136c91883347d1f7f8b9b8;p=packages%2Fo%2Fopenafs.git Remove extra arguments to afs_syscall_call Someone appears to have mistaken afs_syscall_call for afs_syscall_pioctl, and passed rvp and CRED to afs_syscall_call on solaris (afs_syscall_call always takes 6 arguments; afs_syscall_pioctl takes various arguments depending on the platform). After b1ff4a0b1115f5739c0365cc963189b1f931971f, this breaks the client build on AFS_SUN5_ENV, but only because it added prototypes for afs_syscall_call; it looks like it's always been wrong, but it was never noticed. Reviewed-on: http://gerrit.openafs.org/653 Tested-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear --- diff --git a/src/afs/afs_call.c b/src/afs/afs_call.c index 5330008db..6d029c47b 100644 --- a/src/afs/afs_call.c +++ b/src/afs/afs_call.c @@ -1722,11 +1722,7 @@ Afs_syscall() if (uap->syscall == AFSCALL_CALL) { code = afs_syscall_call(uap->parm1, uap->parm2, uap->parm3, uap->parm4, - uap->parm5, uap->parm6 -#ifdef AFS_SUN5_ENV - , rvp, CRED() -#endif - ); + uap->parm5, uap->parm6); } else if (uap->syscall == AFSCALL_SETPAG) { #ifdef AFS_SUN5_ENV register proc_t *procp;