From: Mark Vitale Date: Tue, 16 Feb 2016 19:55:03 +0000 (-0500) Subject: viced: incorrect FID audit of BulkStatus and InlineBulkStatus X-Git-Tag: upstream/1.6.18^2~17 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=86624d4118cc0f50d0096563b615154f0fb1c4f7;p=packages%2Fo%2Fopenafs.git viced: incorrect FID audit of BulkStatus and InlineBulkStatus The audit code for object AUD_FIDS is off by one - we list the first FID twice and skip the last FID. Repair so all FIDs are properly audited. Reviewed-on: http://gerrit.openafs.org/12191 Tested-by: BuildBot Reviewed-by: Chas Williams <3chas3@gmail.com> Reviewed-by: Benjamin Kaduk (cherry picked from commit 44349d0694c7a185fae4c55c75cb01196d109a26) Change-Id: I7f662fd54aaab8182fedc5ebd607db37e501b423 Reviewed-on: https://gerrit.openafs.org/12211 Tested-by: BuildBot Reviewed-by: Mark Vitale Reviewed-by: Stephan Wiesand --- diff --git a/src/audit/audit.c b/src/audit/audit.c index dacbef7e8..17652eeab 100644 --- a/src/audit/audit.c +++ b/src/audit/audit.c @@ -264,9 +264,8 @@ printbuf(int rec, char *audEvent, char *afsName, afs_int32 hostId, vaFid = vaFids->AFSCBFids_val; if (vaFid) { - audit_ops->append_msg("FIDS %u FID %u:%u:%u ", vaFids->AFSCBFids_len, vaFid->Volume, - vaFid->Vnode, vaFid->Unique); - for ( i = 1; i < vaFids->AFSCBFids_len; i++, vaFid++ ) + audit_ops->append_msg("FIDS %u ", vaFids->AFSCBFids_len); + for ( i = 1; i <= vaFids->AFSCBFids_len; i++, vaFid++ ) audit_ops->append_msg("FID %u:%u:%u ", vaFid->Volume, vaFid->Vnode, vaFid->Unique); } else