From: Ben Kaduk <kaduk@mit.edu>
Date: Mon, 20 Dec 2010 00:29:17 +0000 (-0500)
Subject: Zero rx_multi_lock before initializing it
X-Git-Tag: upstream/1.6.0.pre2^2~155
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=8adedcaf5822e88e230c6cd988083d4676251f88;p=packages%2Fo%2Fopenafs.git

Zero rx_multi_lock before initializing it

FreeBSD's kernel debugging facilities will panic if it detects
an attempt to re-initialize an already-initialized lock, as detected
through some particular bits being nonzero.  Zero everything out
before starting, to prevent this panic.

Reviewed-on: http://gerrit.openafs.org/3550
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 37c20528df26a43ec81b8e0f7658f1516d3c1b39)

Change-Id: I7e78989c313269388808c26d521f4075c0749cd4
Reviewed-on: http://gerrit.openafs.org/3638
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
---

diff --git a/src/rx/rx_multi.c b/src/rx/rx_multi.c
index 56b8a8994..cb7186a04 100644
--- a/src/rx/rx_multi.c
+++ b/src/rx/rx_multi.c
@@ -42,6 +42,7 @@ multi_Init(struct rx_connection **conns, int nConns)
     mh = (struct multi_handle *)osi_Alloc(sizeof(struct multi_handle));
     if (!calls || !ready || !mh)
 	osi_Panic("multi_Rx: no mem\n");
+    memset(mh, 0, sizeof(struct multi_handle));
     mh->calls = calls;
     mh->nextReady = mh->firstNotReady = mh->ready = ready;
     mh->nReady = 0;