From: Andrew Deason <adeason@sinenomine.net>
Date: Wed, 30 Oct 2013 02:22:02 +0000 (-0500)
Subject: volserver: Exit on arg parsing failure
X-Git-Tag: upstream/1.8.0_pre1^2~907
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=90d4cbc285071bd5c9b6f9d5096879bc6bb43da1;p=packages%2Fo%2Fopenafs.git

volserver: Exit on arg parsing failure

If ParseArgs returns an error, argument parsing failed. Currently we
keep going anyway, ignoring the error. Exit instead.

Change-Id: I2f9e4e06d6c3fab8e29921bdb0ea30d714c794b1
Reviewed-on: http://gerrit.openafs.org/10422
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/src/volser/volmain.c b/src/volser/volmain.c
index 367a8a800..3b7dfc614 100644
--- a/src/volser/volmain.c
+++ b/src/volser/volmain.c
@@ -445,7 +445,9 @@ main(int argc, char **argv)
     configDir = strdup(AFSDIR_SERVER_ETC_DIRPATH);
     logFile = strdup(AFSDIR_SERVER_VOLSERLOG_FILEPATH);
 
-    ParseArgs(argc, argv);
+    if (ParseArgs(argc, argv)) {
+	exit(1);
+    }
 
     if (auditFileName) {
 	osi_audit_file(auditFileName);