From: Jeffrey Altman Date: Sat, 15 Jan 2011 16:39:39 +0000 (-0500) Subject: vol: initialize FdHandle_t stack objects X-Git-Tag: upstream/1.6.0.pre2^2~76 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=914e70a60309104c81daadc4e12ec294c2b22197;p=packages%2Fo%2Fopenafs.git vol: initialize FdHandle_t stack objects In namei_create() a temporary FdHandle_t is allocated on the stack but was never initialized. Depending on what prior data was on the stack the FdHandle_t could result in subsequent operations failing in unpredictable ways. Reviewed-on: http://gerrit.openafs.org/3667 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 05d5f012e0be9be1c2c82871a75ac76d437b9688) Change-Id: I44913419e09b36a3581320cd169bbc4774cd0208 Reviewed-on: http://gerrit.openafs.org/3829 Tested-by: BuildBot Reviewed-by: Derrick Brashear --- diff --git a/src/vol/namei_ops.c b/src/vol/namei_ops.c index 56d32278a..452213af5 100644 --- a/src/vol/namei_ops.c +++ b/src/vol/namei_ops.c @@ -751,6 +751,7 @@ namei_icreate(IHandle_t * lh, char *part, afs_uint32 p1, afs_uint32 p2, afs_uint b32_string_t str1; memset((void *)&tmp, 0, sizeof(IHandle_t)); + memset(&tfd, 0, sizeof(FdHandle_t)); tmp.ih_dev = nt_DriveToDev(part); if (tmp.ih_dev == -1) { @@ -876,6 +877,7 @@ namei_icreate(IHandle_t * lh, char *part, afs_uint32 p1, afs_uint32 p2, afs_uint int ogm_parm; memset((void *)&tmp, 0, sizeof(IHandle_t)); + memset(&tfd, 0, sizeof(FdHandle_t)); tmp.ih_dev = volutil_GetPartitionID(part); if (tmp.ih_dev == -1) {