From: Simon Wilkinson <sxw@your-file-system.com>
Date: Fri, 15 Feb 2013 17:23:51 +0000 (+0000)
Subject: dumpscan: Unsigned ints can't be less than 0
X-Git-Tag: upstream/1.8.0_pre1^2~1531
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=94eb76caf16558ab39841571df19cec40f732294;p=packages%2Fo%2Fopenafs.git

dumpscan: Unsigned ints can't be less than 0

'y' is an unsigned int, and therefore can never be less than 0, so
don't bother checking if it is.

Caught by clang-analyzer

Change-Id: I65e9e6e2a6f72a4a1a861234c5db89cc9d99ef15
Reviewed-on: http://gerrit.openafs.org/9138
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
---

diff --git a/src/tools/dumpscan/util.c b/src/tools/dumpscan/util.c
index 778eac78c..8179ad56f 100644
--- a/src/tools/dumpscan/util.c
+++ b/src/tools/dumpscan/util.c
@@ -138,7 +138,7 @@ match_next_vnode(XFILE * X, dump_parser * p, dt_uint64 * where,
 	    return DSERR_FMT;
 	if (x > vnode && x - vnode > 10000)
 	    return DSERR_FMT;
-	if (y < 0 || y > p->vol_uniquifier)
+	if (y > p->vol_uniquifier)
 	    return DSERR_FMT;
 
 	/* Now, what follows the vnode/uniquifier? */