From: Jeffrey Hutzelman <jhutz@cs.cmu.edu>
Date: Tue, 20 Jun 2006 21:01:42 +0000 (+0000)
Subject: STABLE14-viced-findclient-do-not-return-wrong-client-20060620
X-Git-Tag: openafs-stable-1_4_2-beta2~32
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=9636e92f090d3166cc5d48afd9a2aa5a8e738a6e;p=packages%2Fo%2Fopenafs.git

STABLE14-viced-findclient-do-not-return-wrong-client-20060620


In h_FindClient_r it was possible for the wrong client to be returned
and worse for it to be returned without the reference count being
incremented.


(cherry picked from commit 06fa1f9c40432747724e6e55154bf54e1e3e94c5)
---

diff --git a/src/viced/host.c b/src/viced/host.c
index 8d87b8dfe..49f098b97 100644
--- a/src/viced/host.c
+++ b/src/viced/host.c
@@ -1609,6 +1609,8 @@ h_FindClient_r(struct rx_connection *tcon)
 	H_UNLOCK;
 	ObtainWriteLock(&client->lock);	/* released at end */
 	H_LOCK;
+    } else {
+	client = NULL;
     }
 
     authClass = rx_SecurityClassOf((struct rx_connection *)tcon);