From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Tue, 2 Sep 2008 23:35:36 +0000 (+0000)
Subject: DEVEL15-windows-afsd-dns-env-20080902
X-Git-Tag: openafs-devel-1_5_53~55
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=96c35b143857945c267618ebb5f03c0305cb75b7;p=packages%2Fo%2Fopenafs.git

DEVEL15-windows-afsd-dns-env-20080902

LICENSE MIT

Fix the conditionals so that the right thing happens if AFS_AFSDB_ENV
is not defined.


(cherry picked from commit 9803e84e63c28e87c76e6f4e77343fec4ef4dcf4)
---

diff --git a/src/WINNT/afsd/cm_cell.c b/src/WINNT/afsd/cm_cell.c
index ceaeb8c95..8432fd2b3 100644
--- a/src/WINNT/afsd/cm_cell.c
+++ b/src/WINNT/afsd/cm_cell.c
@@ -100,8 +100,13 @@ cm_cell_t *cm_UpdateCell(cm_cell_t * cp, afs_uint32 flags)
         rock.cellp = cp;
         rock.flags = flags;
         code = cm_SearchCellFile(cp->name, NULL, cm_AddCellProc, &rock);
+        if (code == 0) {
+            lock_ObtainMutex(&cp->mx);
+	    cp->timeout = time(0) + 7200;
+            lock_ReleaseMutex(&cp->mx);
+        }
 #ifdef AFS_AFSDB_ENV
-        if (code) {
+        else {
             if (cm_dnsEnabled) {
                 int ttl;
 
@@ -124,13 +129,8 @@ cm_cell_t *cm_UpdateCell(cm_cell_t * cp, afs_uint32 flags)
                     lock_ReleaseMutex(&cp->mx);
                 }
 	    }
-	} else 
+	}
 #endif /* AFS_AFSDB_ENV */
-	{
-            lock_ObtainMutex(&cp->mx);
-	    cp->timeout = time(0) + 7200;
-            lock_ReleaseMutex(&cp->mx);
-	}	
     } else {
         lock_ReleaseMutex(&cp->mx);
     }
@@ -277,8 +277,9 @@ cm_cell_t *cm_GetCell_Gen(char *namep, char *newnamep, afs_uint32 flags)
                     cp->timeout = time(0) + ttl;
                 }
             } 
+            else 
 #endif
-            else {
+            {
                 cm_FreeCell(cp);
                 cp = NULL;
                 goto done;