From: Stephan Wiesand <stephan.wiesand@desy.de>
Date: Fri, 30 May 2014 13:05:28 +0000 (+0200)
Subject: libadmin: Remove redundant memset call
X-Git-Tag: upstream/1.6.10_pre1^2~100
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=9c7f4490af8582c943f115474df645e825ad4cff;p=packages%2Fo%2Fopenafs.git

libadmin: Remove redundant memset call

Commit bf78bf2c115659b78c34d3bc9d1934bcff21c8cc added initialisation
of the nbulkentries structure to 0, to avoid freeing garbage due to a
goto fail_... before the structure is initialised. As pointed out by
Andrew Deason, there already is an equivalent memset call later in the
code which is now redundant. Remove it.

Reviewed-on: http://gerrit.openafs.org/11180
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit f05abc47938beddb436fd0b9677f7b59fc64a215)

Change-Id: I7338e42a45d0871af2ad404191ab622605172ac3
Reviewed-on: http://gerrit.openafs.org/11195
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
---

diff --git a/src/libadmin/vos/afs_vosAdmin.c b/src/libadmin/vos/afs_vosAdmin.c
index 55978e5fb..bed8c494f 100644
--- a/src/libadmin/vos/afs_vosAdmin.c
+++ b/src/libadmin/vos/afs_vosAdmin.c
@@ -381,8 +381,6 @@ vos_BackupVolumeCreateMultiple(const void *cellHandle,
 	prefix_len = strlen(volumePrefix);
     }
 
-    memset((void *)&arrayEntries, 0, sizeof(arrayEntries));
-
     /*
      * Get a list of all the volumes in the cell
      */