From: Gabriel Filion <gabster@lelutin.ca>
Date: Thu, 20 Nov 2014 22:07:11 +0000 (-0500)
Subject: Call add_error() with one arg on readlink failure
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=9d6a70f48926fcbb84e39c909c0e8a8843a17154;p=packages%2Fb%2Fbup.git

Call add_error() with one arg on readlink failure

...instead of two.

This bug and its solution was found by Ben Kelly.

Signed-off-by: Gabriel Filion <gabster@lelutin.ca>
[rlb@defaultvalue.org: adjust commit message]
Reviewed-by: Rob Browning <rlb@defaultvalue.org>
---

diff --git a/lib/bup/metadata.py b/lib/bup/metadata.py
index 685c663..8a84f11 100644
--- a/lib/bup/metadata.py
+++ b/lib/bup/metadata.py
@@ -446,7 +446,7 @@ class Metadata:
             if stat.S_ISLNK(st.st_mode):
                 self.symlink_target = os.readlink(path)
         except OSError, e:
-            add_error('readlink: %s', e)
+            add_error('readlink: %s' % e)
 
     def _encode_symlink_target(self):
         return self.symlink_target