From: Jeffrey Altman <jaltman@your-file-system.com>
Date: Fri, 2 Dec 2011 23:49:23 +0000 (-0500)
Subject: Windows: GetInfoTip really set return to NULL
X-Git-Tag: upstream/1.8.0_pre1^2~2984
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=9de84a1e67cb3570dedef4ac4552901210b19e5f;p=packages%2Fo%2Fopenafs.git

Windows: GetInfoTip really set return to NULL

When we are not returning an info-tip string from the shell
extension the string output parameter must be set to NULL.

Change-Id: I63cd9bbe078edd01e62d4b0c810a513dfbf205ae
Reviewed-on: http://gerrit.openafs.org/6183
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
---

diff --git a/src/WINNT/client_exp/shell_ext.cpp b/src/WINNT/client_exp/shell_ext.cpp
index fab7d6b57..2f916f875 100644
--- a/src/WINNT/client_exp/shell_ext.cpp
+++ b/src/WINNT/client_exp/shell_ext.cpp
@@ -805,14 +805,14 @@ STDMETHODIMP CShellExt::XToolTipExt::GetInfoTip(DWORD dwFlags, LPWSTR *ppwszTip)
 
     if ((_tcslen(pThis->m_szFile) == 0)||(!IsPathInAfs(pThis->m_szFile)))
     {
-        ppwszTip=NULL;
+        *ppwszTip=NULL;
         return S_OK;
     }
     bool bIsSymlink = !!IsSymlink(pThis->m_szFile);
     bool bIsMountpoint = !!IsMountPoint(pThis->m_szFile);
     if ((!bIsSymlink) && (!bIsMountpoint))
     {
-	ppwszTip=NULL;
+	*ppwszTip=NULL;
 	return S_OK;
     }
     USES_CONVERSION;