From: Derrick Brashear <shadow@your-file-system.com>
Date: Wed, 26 Sep 2012 11:37:11 +0000 (-0400)
Subject: auth: token jar handling should realloc correctly
X-Git-Tag: upstream/1.8.0_pre1^2~1964
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=a060159b95c0d29afaee1e8eac5827c7f8b40e47;p=packages%2Fo%2Fopenafs.git

auth: token jar handling should realloc correctly

instead of reallocing n+1 tokens, we would realloc 1 token
plus N bytes

Change-Id: Idb5a20b5b9becc9d48cb645bbc0bd26459220ccd
Reviewed-on: http://gerrit.openafs.org/8163
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/src/auth/token.c b/src/auth/token.c
index 9d99a1e68..5e1054383 100644
--- a/src/auth/token.c
+++ b/src/auth/token.c
@@ -174,7 +174,7 @@ addOpaque(struct ktc_setTokenData *jar, char *data, size_t len)
 
     entry = jar->tokens.tokens_len;
     jar->tokens.tokens_val = realloc(jar->tokens.tokens_val,
-				     entry + 1 * sizeof(token_opaque));
+				     (entry + 1) * sizeof(token_opaque));
     jar->tokens.tokens_len++;
     jar->tokens.tokens_val[entry].token_opaque_val = data;
     jar->tokens.tokens_val[entry].token_opaque_len = len;